fix: update text in search field when clicking on suggestion #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bnyro
reviewed
Mar 19, 2024
|
Thanks for your PR, what you said above absolutely makes sense 👍 I think that the |
Bnyro
changed the title
guemax
force-pushed
the
update-search-text-when-clicking-on-suggestion
branch
from
514c5b5 to
b9c9025
Compare
Bnyro
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the text in the search field only updates itself when you select a suggestion via the up/down arrow keys, but not when clicking on a suggestion with the left mouse button. However, the
h1element below the input field changes in both cases. I personally find this quite irritating.It seems like this is unintended behavior: There is a function named
onClick(i)which does exactly the thing I would like to have, but apparently it is never called anywhere.Thanks in advance for your answer!